[bisq-network/bisq] Add "Buy BSQ" button next to trade fee selector (#5055)

Christoph Atteneder notifications at github.com
Thu Sep 30 12:09:36 CEST 2021


Although this is kind of repetitive, I see following open points/issues:
- [ ] 1. If `Create offer` is already open it will focus in the `Sell BTC` tab the Filter by Currency dropdown, instead of pre-selecting `BSQ`
<img width="1586" alt="Bildschirmfoto 2021-09-30 um 11 28 50" src="https://user-images.githubusercontent.com/170962/135427076-07da2982-8f78-41e0-ac5f-efb61e1a684a.png">

- [ ] 2. Just showing `Buy BSQ` IMO is keeping the user in the void, what will happen when clicking on it.
<img width="1342" alt="Bildschirmfoto 2021-09-30 um 11 31 51" src="https://user-images.githubusercontent.com/170962/135427281-92f9f6b8-3338-4406-b56c-f457ad9d7f18.png">
I think it needs at least an additional help link as suggested in one of @pedromvpg 's screens
<img width="888" alt="Bildschirmfoto 2021-09-30 um 11 33 01" src="https://user-images.githubusercontent.com/170962/135427423-3b4c3cf4-76da-4dbf-89a2-5fb0950026c0.png">

- [ ] 3. Having `Create Offer` open in `Sell BTC` section, will close the `Create Offer` Tab when clicking on `Buy BSQ` in the `Buy BTC > Take offer` or `Sell BTC > Create Offer` section.
**Before**
![Bildschirmfoto 2021-09-30 um 11 49 22](https://user-images.githubusercontent.com/170962/135429873-179b36f8-d6a3-4756-8878-944e5ec11db6.png)

**After clicking on `Buy BSQ`**
![Bildschirmfoto 2021-09-30 um 11 40 51](https://user-images.githubusercontent.com/170962/135428625-549ca806-37d9-4c1d-9267-414b4dcd3a57.png)

- [ ]  4. Don't show `Buy BSQ` when trying to buy BSQ
![Bildschirmfoto 2021-09-30 um 11 44 34](https://user-images.githubusercontent.com/170962/135429149-07d65f7f-178c-45e5-a8bd-f45ff0aefb21.png)

- [ ] 5. Process of creating a BSQ account is unclear for new users
When trying to buy BSQ user is guided to create a matching payment account.
![Bildschirmfoto 2021-09-30 um 11 54 29](https://user-images.githubusercontent.com/170962/135430817-8c7514a5-a2dc-4708-aa3a-87358a47e409.png)
Clicking on `Go to "Account"` will open the account tab in the wrong section and if the user manages to understand that she needs to go to `Altcoin Accounts` and search for BSQ. Where do I get the BSQ address from?
![Bildschirmfoto 2021-09-30 um 11 57 27](https://user-images.githubusercontent.com/170962/135431218-32fafe9e-dddd-4e2e-9002-60e39aaf4801.png)
I do think as suggested by @Jakub-CZ that we should automatically create a BSQ Altcoin account and provide the user with the information where she can find the BSQ wallet later on for confirming a trade. 
We should also add in the `Confirm Payment Receipt` screen similar to the `Start payment` screen a button link to the BSQ wallet. In this case maybe something like `Show Payment in BSQ wallet`.

@Jakub-CZ Did I miss any open points?
@Conza88 @pazza83 Any other open points from your point of view that need to be addressed in this PR?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-931183094
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210930/195e6c24/attachment.htm>


More information about the bisq-github mailing list