[bisq-network/bisq] Support Bitcoin Core v22 RPC for JSON export (PR #6123)

[jmacxx]

@jmacxx commented on this pull request.



> @@ -350,9 +352,14 @@ private static RawTx getTxFromRawTransaction(RawDtoTransaction rawDtoTx,
                                     }
                                 }
                             }
-                            // We don't support raw MS which are the only case where scriptPubKey.getAddresses()>1
-                            String address = scriptPubKey.getAddresses() != null &&

The test failed, DAO hashes no longer matched with the seednodes.  Investigation showed that the `addresses` field makes its way into the DAO state records and thus when it is null, affects the DAO state hash.  The way to solve this is to generate the addresses field if necessary at the point we get DtoPubKeyScript from bitcoind.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6123#discussion_r841286113
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6123/review/929728464 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220403/7d0fff83/attachment.htm>