[bisq-network/bisq] Fix the avatar tradecount tag to include BSQ Swap trades. (PR #6134)

jmacxx notifications at github.com
Wed Apr 6 00:35:31 CEST 2022


The counter shown on a peer's avatar indicates how many trades you have done with that peer.  BSQ swaps are currently not reflected in that count, so if you were looking on a peer avatar it would indicate either:

- that you have not traded with that peer (even if you have done BSQ swaps with them), or
- that you have traded with them 'n' times, representing the number of **non-BSQ swap** trades.
 
This PR fixes the issue by counting the number of regular trades and BSQ swap trades.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6134

-- Commit Summary --

  * Fix the tradecount tag to include Bsq Swap trades.

-- File Changes --

    M core/src/main/java/bisq/core/trade/ClosedTradableManager.java (5)
    M core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapTradeManager.java (5)
    M core/src/main/java/bisq/core/trade/model/Tradable.java (6)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (15)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6134.patch
https://github.com/bisq-network/bisq/pull/6134.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6134
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6134 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220405/6286a6d1/attachment.htm>


More information about the bisq-github mailing list