[bisq-network/bisq] [WIP] Improve navigation structure (PR #6135)

Wed Apr 6 18:06:41 CEST 2022

Based on https://github.com/bisq-network/bisq/discussions/6092 this is the PR that implements all required changes.
I hope I have covered everything, but it is a lot of testing.

<img width="1439" alt="Bildschirmfoto 2022-04-06 um 18 03 16" src="https://user-images.githubusercontent.com/170962/162018509-2e6ce3c5-e7c2-4d1c-b396-b044edf5dc39.png">
<img width="1439" alt="Bildschirmfoto 2022-04-06 um 18 02 33" src="https://user-images.githubusercontent.com/170962/162018526-ae991ac4-6401-4c29-9124-09cb14c4dec6.png">
<img width="1439" alt="Bildschirmfoto 2022-04-06 um 18 02 28" src="https://user-images.githubusercontent.com/170962/162018538-821ac8d2-7dd3-4588-abfa-5ce176fa8f17.png">
<img width="1439" alt="Bildschirmfoto 2022-04-06 um 18 02 24" src="https://user-images.githubusercontent.com/170962/162018546-36f24043-581e-4816-aed7-de07df75ba90.png">
<img width="1439" alt="Bildschirmfoto 2022-04-06 um 18 02 19" src="https://user-images.githubusercontent.com/170962/162018552-ac116f3c-918f-4ff0-aa9b-447f9974b03b.png">

Anyone who wants to give it a shot and provide feedback is more than welcome.
This PR also includes improvements in other areas as well (e.g. only Payment methods are shown in filter for selected currency) and many more.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6135

-- Commit Summary --

  * Adapt navigational structure and offerbook handling to buy and sell different assets
  * Adapt offer book chart view to new navigational structure
  * Add payment account filtering for remaining payment methods
  * Add missing payment account filtering
  * Show all payment methods
  * Adapt take offer process to new navigation structure
  * Adapt create offer process to new navigation structure

-- File Changes --

    M core/src/main/java/bisq/core/locale/CurrencyUtil.java (116)
    M core/src/main/java/bisq/core/payment/AliPayAccount.java (4)
    M core/src/main/java/bisq/core/payment/AustraliaPayid.java (4)
    M core/src/main/java/bisq/core/payment/CashAppAccount.java (4)
    M core/src/main/java/bisq/core/payment/ChaseQuickPayAccount.java (4)
    M core/src/main/java/bisq/core/payment/ClearXchangeAccount.java (4)
    M core/src/main/java/bisq/core/payment/FasterPaymentsAccount.java (4)
    M core/src/main/java/bisq/core/payment/HalCashAccount.java (4)
    M core/src/main/java/bisq/core/payment/InteracETransferAccount.java (4)
    M core/src/main/java/bisq/core/payment/JapanBankAccount.java (4)
    M core/src/main/java/bisq/core/payment/MoneyBeamAccount.java (4)
    M core/src/main/java/bisq/core/payment/PaymentAccountUtil.java (115)
    M core/src/main/java/bisq/core/payment/PerfectMoneyAccount.java (4)
    M core/src/main/java/bisq/core/payment/PopmoneyAccount.java (4)
    M core/src/main/java/bisq/core/payment/PromptPayAccount.java (4)
    M core/src/main/java/bisq/core/payment/SwishAccount.java (4)
    M core/src/main/java/bisq/core/payment/USPostalMoneyOrderAccount.java (4)
    M core/src/main/java/bisq/core/payment/VenmoAccount.java (4)
    M core/src/main/java/bisq/core/payment/WeChatPayAccount.java (4)
    M core/src/main/java/bisq/core/user/Preferences.java (10)
    M core/src/main/java/bisq/core/user/PreferencesPayload.java (8)
    M core/src/main/resources/i18n/displayStrings.properties (38)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/BizumForm.java (8)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/IfscBankForm.java (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/NequiForm.java (8)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/PaytmForm.java (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/PixForm.java (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/SatispayForm.java (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/StrikeForm.java (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/TikkieForm.java (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/TransferwiseUsdForm.java (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/UpiForm.java (4)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (142)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java (25)
    M desktop/src/main/java/bisq/desktop/main/offer/BuyOfferView.java (1)
    A desktop/src/main/java/bisq/desktop/main/offer/ClosableView.java (22)
    A desktop/src/main/java/bisq/desktop/main/offer/InitializableViewWithTakeOfferData.java (26)
    M desktop/src/main/java/bisq/desktop/main/offer/OfferView.java (421)
    A desktop/src/main/java/bisq/desktop/main/offer/SelectableView.java (22)
    M desktop/src/main/java/bisq/desktop/main/offer/SellOfferView.java (3)
    M desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferDataModel.java (21)
    M desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferView.java (67)
    M desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferViewModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/OfferViewUtil.java (35)
    M desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/createoffer/CreateOfferView.java (41)
    M desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/takeoffer/TakeOfferView.java (36)
    M desktop/src/main/java/bisq/desktop/main/offer/bsq_swap/BsqSwapOfferView.java (3)
    M desktop/src/main/java/bisq/desktop/main/offer/bsq_swap/create_offer/BsqSwapCreateOfferView.java (9)
    M desktop/src/main/java/bisq/desktop/main/offer/bsq_swap/take_offer/BsqSwapTakeOfferView.java (11)
    R desktop/src/main/java/bisq/desktop/main/offer/offerbook/BsqOfferBookView.fxml (2)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/BsqOfferBookView.java (79)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/BsqOfferBookViewModel.java (120)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/BtcOfferBookView.fxml (30)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/BtcOfferBookView.java (69)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/BtcOfferBookViewModel.java (139)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (118)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (71)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/OtherOfferBookView.fxml (30)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/OtherOfferBookView.java (67)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/OtherOfferBookViewModel.java (150)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/TopAltcoinOfferBookView.fxml (30)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/TopAltcoinOfferBookView.java (77)
    A desktop/src/main/java/bisq/desktop/main/offer/offerbook/TopAltcoinOfferBookViewModel.java (120)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/BsqSwapOfferDetailsWindow.java (13)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java (24)
    M desktop/src/main/java/bisq/desktop/main/portfolio/duplicateoffer/DuplicateOfferView.java (18)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferView.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/presentation/PortfolioUtil.java (8)
    M desktop/src/test/java/bisq/desktop/main/offer/offerbook/OfferBookViewModelTest.java (22)
    M proto/src/main/proto/pb.proto (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6135.patch
https://github.com/bisq-network/bisq/pull/6135.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6135
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6135 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220406/bb042c27/attachment-0001.htm>