[bisq-network/bisq] Prevent multiple payout screens when agent repeat clicks on close ticket. (PR #6136)

[xyzmaker123]

@xyzmaker123 approved this pull request.

utACK (with small refactoring suggestion)

Maybe it would be good to search for other places where multiple popups could be shown (search for "`new Popup()`" in code base). More generic solution could be also considered.

> @@ -132,6 +132,7 @@
     private ChangeListener<Toggle> tradeAmountToggleGroupListener;
     private ChangeListener<String> compensationOrPenaltyListener;
     private boolean updatingUi = false;
+    private boolean payoutPromptOnDisplay = false;

I see alternative approach in code base in [`DaoStateMonitorView`](https://github.com/bisq-network/bisq/blob/8e3f95383e1c1784cf7cb735b345e2a73b8456c9/desktop/src/main/java/bisq/desktop/main/dao/monitor/daostate/DaoStateMonitorView.java#L65) and [`TradeStepView`](https://github.com/bisq-network/bisq/blob/ee374c3c39720e540a79311d48a1d6daa93d8abd/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/TradeStepView.java#L106) where `Popup` instance is stored instead of boolean. To be more consistent we could choose single way.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6136#pullrequestreview-935002574
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6136/review/935002574 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220407/3276b8fe/attachment.htm>