[bisq-network/bisq] [WIP] Improve navigation structure (PR #6135)
Christoph Atteneder
notifications at github.com
Thu Apr 7 19:54:22 CEST 2022
@ripcurlx commented on this pull request.
> @@ -502,6 +506,114 @@ public static void setBaseCurrencyCode(String baseCurrencyCode) {
return currencies;
}
+ public static List<TradeCurrency> getAllInteracETransferIdCurrencies() {
Yes, I agree that it would make more sense to move this information closer to the Domain. I didn't spend too much time yet on bigger refactorings to prevent too many unexpected side effects by changing too much. But yes, I think moving it the PaymentMethod would make sense. Although it is a 1:1 relationship all the time AFAIK, but I think it would be a better fit for the PaymentMethod, which is used by the Payment Account.
--
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6135#discussion_r845419676
You are receiving this because you are subscribed to this thread.
Message ID: <bisq-network/bisq/pull/6135/review/935468066 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220407/430bc00e/attachment.htm>
More information about the bisq-github
mailing list