[bisq-network/bisq] [WIP] Improve navigation structure (PR #6135)

Christoph Atteneder notifications at github.com
Mon Apr 11 09:29:17 CEST 2022


> Checked it out, looks good! (Some niggles need ironing out).
> 
> * Creating BSQ swap offer it somehow is mixing `BSQ Swap` with `Altcoin`, because the offer that gets created has a security deposit Tx and gets displayed like an altcoin offer even though it says "BSQ Swap" as offer type.  When that offer gets taken the trade fails with "hash of payment account is invalid".  This is a clean build from your current branch, run on a fresh regtest env with no altcoin accounts.
> * Clicking on an offer in Market View does not always take me to the market containing that offer.  e.g. There is only one offer in the market a Buy BSQ offer.  In Market View click on the offer.  It takes me to Sell BTC for Fiat, and has BSQ selected in the currency drop down.  No offer is shown.

Thanks for testing - I'll look at the BSQ Swap issue you experienced in more detail. It did work for me, so it is kind of weird. I'll post an update today as soon as I'm through with my testing.

@Market View: It can be that there is an issue. I only fixed the behavior on the buy/sell buttons, but not on the triggers in each row. Quite a bit of changes this change caused in the end 😅 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6135#issuecomment-1094649050
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6135/c1094649050 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220411/52ba5380/attachment.htm>


More information about the bisq-github mailing list