[bisq-network/bisq] Add inbound Tor connectivity test (PR #6147)
jmacxx
notifications at github.com
Tue Apr 12 21:47:36 CEST 2022
A user set up Bisq on Whonix. While Bisq appears to run correctly, their open offers were not able to be taken - rejected with the error message "Maker is offline". After a while the user was contacted by the support team with a private notification suggesting they clear the Tor cache and restart (the normal suggested resolution for connectivity issues).
The user made a good suggestion that Bisq should do a test attempting to connect back to itself over Tor. If that fails then show a message informing them to check their firewall configuration. This PR implements that. The test runs after Bisq has fully initialized.
![Screenshot from 2022-04-12 13-24-34](https://user-images.githubusercontent.com/47253594/163039123-c8b530c5-e71b-4fa7-8c5a-6153d3a1292a.png)
Fixes #6142
Fixes #6141
### Testing
- In a normal mainnet setup, ran Bisq and the connection to self was successful.
- On Whonix, ran Bisq and the connection to self was unsuccessful resulting in the above popup.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/6147
-- Commit Summary --
* Add inbound Tor connectivity test.
-- File Changes --
M core/src/main/java/bisq/core/alert/PrivateNotificationManager.java (52)
M core/src/main/java/bisq/core/app/BisqHeadlessApp.java (1)
M core/src/main/java/bisq/core/app/BisqSetup.java (27)
M core/src/main/resources/i18n/displayStrings.properties (3)
M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (9)
M p2p/src/main/java/bisq/network/p2p/network/NetworkNode.java (2)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/6147.patch
https://github.com/bisq-network/bisq/pull/6147.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6147
You are receiving this because you are subscribed to this thread.
Message ID: <bisq-network/bisq/pull/6147 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220412/af5abfc0/attachment.htm>
More information about the bisq-github
mailing list