[bisq-network/bisq] Fix localization issue when accessing directories and JAR resource paths (PR #6148)

[jmacxx]

Fixes #5722 
Fixes #6144 

Two problems were encountered under Windows with the locale and language set to Turkish:

1. JAR-contained resource `btc_mainnet.seednodes` could not be located because the "i" was translated to "ı" resulting in no seednodes being known.
2. the Bisq data directory `btc_mainnet` was created as `btc_maınnet` and as a result Tor would not start.
  
The solution in both cases is to tell `.toLowerCase()` to use Locale.ENGLISH because directory names such as btc_mainnet are locale-insensitive.


Ref:
https://stackoverflow.com/questions/10336730/which-locale-should-i-specify-when-i-call-stringtolowercase
https://stackoverflow.com/questions/11063102/using-locales-with-javas-tolowercase-and-touppercase#11063161

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6148

-- Commit Summary --

  * Use Locale.ENGLISH when accessing directories and JAR resource paths.

-- File Changes --

    M common/src/main/java/bisq/common/config/Config.java (3)
    M core/src/main/java/bisq/core/network/p2p/seed/DefaultSeedNodeRepository.java (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6148.patch
https://github.com/bisq-network/bisq/pull/6148.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6148
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6148 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220412/4e08650b/attachment.htm>