[bisq-network/bisq] Improve navigation structure (PR #6135)

xyzmaker123 notifications at github.com
Wed Apr 13 14:53:48 CEST 2022


Thanks! I'll review and test this pull request today afternoon or tomorrow if you're okay to wait.

> I didn't remove XMR and BSQ in the end from the preferences list, as it would have lots of unwanted side effects

I searched for `preferences.getCryptoCurrencies` and I see only two usages: [A](https://github.com/bisq-network/bisq/blob/fce247cbc0a1f1bf84db9ebbe814b474675a5e79/desktop/src/main/java/bisq/desktop/main/offer/offerbook/OtherOfferBookViewModel.java#L103-L105) and [B](https://github.com/bisq-network/bisq/blob/064335716ad8d34b04f8aff6e21831d09f2a5b81/desktop/src/main/java/bisq/desktop/util/CurrencyList.java#L117). As an alternative approach we could extend this list with XMR and BSQ in B situation, and eliminate `withoutBSQAndTopAltcoin` in filter A. However I don't have strong opinion here - in both cases user could be confused what he is really configuring in preferences.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6135#issuecomment-1098014986
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6135/c1098014986 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220413/61c4e550/attachment.htm>


More information about the bisq-github mailing list