[bisq-network/bisq] Fix NPE when editing same bank account name (PR #6167)

[Christoph Atteneder]

@ripcurlx commented on this pull request.



> +
+
+        BankAccountPayload bankAccountPayload = null;
+        CashDepositAccountPayload cashDepositAccountPayload = null;
+        if (paymentAccountPayload instanceof BankAccountPayload) {
+            bankAccountPayload = (BankAccountPayload) paymentAccountPayload;
+        } else if (paymentAccountPayload instanceof CashDepositAccountPayload) {
+            cashDepositAccountPayload = (CashDepositAccountPayload) paymentAccountPayload;
+        }
+

I don't like it so much having those checks in the abstract class for specific implementations. I think it would be better to have a getBankId, getBranchId, getBankName and getAccountNr implementation in the CashDeposit and BankAccount forms WDYT?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6167#pullrequestreview-953203704
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6167/review/953203704 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220426/2d823a20/attachment.htm>