[bisq-network/bisq] Check current fee receiver list whenever a fee tx is validated. (PR #6182)

jmacxx notifications at github.com
Fri Apr 29 18:50:47 CEST 2022


Had an issue in support: the current [BTC fee receiver address](https://mempool.space/address/38bZBj5peYS3Husdz7AH3gEUiUbYRD951t) was not recognized when checking a taker fee payment.

This caused mediation to start, analysis of logs showed that the first seednode did not provide any filter objects, and so caused the validator to be initialized without the fee address which comes from the filter.  (The data downloaded from the second seednode did contain 2 filter objects, but by that time initialization had already passed).

This change addresses the issue by obtaining the fee addresses each time a fee payment is validated, instead of a snapshot upon service initialization.  There's no overhead since the fee addresses are already stored in memory, and the benefit is that whenever a new filter is received, its contents are used.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6182

-- Commit Summary --

  * Refresh current fee receiver list whenever a fee tx is validated.

-- File Changes --

    M core/src/main/java/bisq/core/provider/mempool/MempoolService.java (8)
    M core/src/main/java/bisq/core/provider/mempool/TxValidator.java (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6182.patch
https://github.com/bisq-network/bisq/pull/6182.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6182
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6182 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220429/32d05936/attachment.htm>


More information about the bisq-github mailing list