[bisq-network/bisq] Sign/Verify message for DAO bonded roles (PR #6032)

[chimp1984]

@chimp1984 requested changes on this pull request.

Looks good to me. Small nits...

> @@ -75,4 +75,12 @@ public boolean isLockupButtonVisible() {
     public boolean isRevokeButtonVisible() {
         return this.daoFacade.isMyRole(this.getRole()) && (this.bondedRole.getBondState() == BondState.LOCKUP_TX_CONFIRMED);
     }
+
+    public boolean isSignButtonVisible() {
+        return this.daoFacade.isMyRole(this.getRole()) && (this.bondedRole.getBondState() == BondState.LOCKUP_TX_CONFIRMED);
+    }
+
+    public boolean isVerifyButtonVisible() {
+        return getLockupTxId() != null && getLockupTxId().length() > 1;

Shouldn't be here the same as in isSignButtonVisible and isRevokeButtonVisible ?
Could be extracted to one method.

> @@ -75,4 +75,12 @@ public boolean isLockupButtonVisible() {
     public boolean isRevokeButtonVisible() {
         return this.daoFacade.isMyRole(this.getRole()) && (this.bondedRole.getBondState() == BondState.LOCKUP_TX_CONFIRMED);
     }
+
+    public boolean isSignButtonVisible() {
+        return this.daoFacade.isMyRole(this.getRole()) && (this.bondedRole.getBondState() == BondState.LOCKUP_TX_CONFIRMED);
+    }
+
+    public boolean isVerifyButtonVisible() {
+        return getLockupTxId() != null && getLockupTxId().length() > 1;

Ah the unlocked case is different to isRevokeButtonVisible...
Maybe to make it more explicit to add methods for the possible states?
- not locked up
- locked up
- unlocked

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6032#pullrequestreview-877539260
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6032/review/877539260 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220209/105403f1/attachment-0001.htm>