[bisq-network/bisq] Fix issue selecting specific BSQ UTXO for send. (PR #6040)

jmacxx notifications at github.com
Fri Feb 11 18:39:09 CET 2022


Fixes #6023

### UI Issue:

- The UI for selecting UTXO inputs was being resized to the number of UTXO available, which caused problems when there is a large set.  Solution is to size the UI to accomodate 3 to 15 rows, which provides a reasonable screen display and a scrollbar for the case of a large UTXO set.

### Transaction issue:

- The `BisqDefaultCoinSelector` is invoked multiple times when a transaction is being built.  Problem was that the coin selection was being reset within, ultimately leading to coin selection being completely ignored.  Solution is to keep the coin selection, resetting after the transaction has been built.



---

<details>
 <summary>Screenshots</summary>

example no UTXO

![image](https://user-images.githubusercontent.com/47253594/153639826-95482972-b489-4844-a792-3808230301ad.png)


example 2 utxo

![image](https://user-images.githubusercontent.com/47253594/153639624-173913ef-c8f2-484b-82f4-1477d63ded94.png)


fabricated example 100 utxo with scrollbar

![image](https://user-images.githubusercontent.com/47253594/153640572-7196f835-9727-424b-adf7-223927c66c3e.png)



</details>

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6040

-- Commit Summary --

  * Fix issue selecting specific BSQ UTX for send.

-- File Changes --

    M core/src/main/java/bisq/core/btc/wallet/BisqDefaultCoinSelector.java (4)
    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TxInputSelectionWindow.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6040.patch
https://github.com/bisq-network/bisq/pull/6040.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6040
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6040 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220211/85d72f08/attachment-0001.htm>


More information about the bisq-github mailing list