[bisq-network/bisq] Change API's OfferInfo proto's price field to string (PR #6056)

[Stan]

As a long, it created confusion and extra client side code for handling display of offer altcoin prices to 8 decimal places, and fiat prices to 4 decimal places.

Based on branch `1-prep-for-offer-service-proto-changes`, PR https://github.com/bisq-network/bisq/pull/6055
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6056

-- Commit Summary --

  * Include unmerged API NPE fix to FeeService class (see PR #6052)
  * Prepare API Offers .proto defs for significant changes
  * Fix comment about changing "all" number fields to string
  * Delete deprecated CLI console output formatting classes
  * Change OfferInfo proto's 'price' field type to string
  * Adjust cli module to OfferInfo.price field change to string  type
  * Fix typo in comment
  * Adjust apitest cases to OfferInfo.price proto field type to string

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (22)
    M apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (17)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateXMROffersTest.java (8)
    M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (106)
    M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapBuyBtcTradeTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapSellBtcTradeTest.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java (4)
    M apitest/src/test/java/bisq/apitest/scenario/bot/RobotBob.java (12)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/BotProtocol.java (11)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/MakerBotProtocol.java (12)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/TakerBotProtocol.java (5)
    D cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (81)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (1)
    D cli/src/main/java/bisq/cli/DirectionFormat.java (61)
    D cli/src/main/java/bisq/cli/OfferFormat.java (309)
    D cli/src/main/java/bisq/cli/TableFormat.java (156)
    D cli/src/main/java/bisq/cli/TradeFormat.java (222)
    D cli/src/main/java/bisq/cli/TransactionFormat.java (60)
    M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (15)
    M cli/src/main/java/bisq/cli/table/builder/OfferTableBuilder.java (14)
    M cli/src/test/java/bisq/cli/table/AddressCliOutputDiffTest.java (17)
    M cli/src/test/java/bisq/cli/table/GetBalanceCliOutputDiffTest.java (15)
    M cli/src/test/java/bisq/cli/table/GetOffersCliOutputDiffTest.java (9)
    M cli/src/test/java/bisq/cli/table/GetTradeCliOutputDiffTest.java (9)
    M cli/src/test/java/bisq/cli/table/GetTransactionCliOutputDiffTest.java (10)
    M cli/src/test/java/bisq/cli/table/PaymentAccountsCliOutputDiffTest.java (9)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (8)
    M core/src/main/java/bisq/core/api/model/builder/OfferInfoBuilder.java (4)
    M core/src/main/java/bisq/core/provider/fee/FeeService.java (2)
    M proto/src/main/proto/grpc.proto (223)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6056.patch
https://github.com/bisq-network/bisq/pull/6056.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6056
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6056 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220217/a3d9753e/attachment-0001.htm>