[bisq-network/bisq] Change API OfferInfo volume/minVolume proto fields to string [#4] (PR #6060)

[Stan]

As longs, they created confusion and extra client side code for handling display of altcoin volumes to 2 decimal places, and fiat volumes to 0 decimal places.
				
- Change `OfferInfo` proto's volume fields' type to string.
- Adjust cli module to `grpc.proto`'s `volume` & `minVolume` field type change (string).
- Add test asserts on volume/min-volume strings from server.

Based on branch `3-change-grpc-proto-triggerprice-to-string`, PR https://github.com/bisq-network/bisq/pull/6057

Next PR:  Change TradeInfo proto's `tradeVolume` field from long to string.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6060

-- Commit Summary --

  * Include unmerged API NPE fix to FeeService class (see PR #6052)
  * Prepare API Offers .proto defs for significant changes
  * Fix comment about changing "all" number fields to string
  * Delete deprecated CLI console output formatting classes
  * Change OfferInfo proto's 'price' field type to string
  * Adjust cli module to OfferInfo.price field change to string  type
  * Fix typo in comment
  * Adjust apitest cases to OfferInfo.price proto field type to string
  * Fix 'unnecessary use of fully qualified name'.
  * Change existing `uint64 triggerPrice` field type in grpc.proto to `string triggerPrice`.
  * Adjust to `string triggerPrice` change in API core classes.
  * Adjust to `string triggerPrice` change in API cli classes
  * Adjust to `string triggerPrice` change in API test cases
  * Change OfferInfo proto's volume fields' type to string
  * Adjust cli module to grpc.proto::volume field type change (string)
  * Remove some dead code
  * Add some asserts on volume/min-volume strings from server
  * Merge branch 'master' into 4-change-grpc-proto-volume-to-string

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (41)
    M apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (44)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (30)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (37)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateXMROffersTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (202)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapBuyBtcTradeTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapSellBtcTradeTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java (26)
    M apitest/src/test/java/bisq/apitest/scenario/bot/BotClient.java (3)
    M apitest/src/test/java/bisq/apitest/scenario/bot/RandomOffer.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/bot/RobotBob.java (12)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/BotProtocol.java (11)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/MakerBotProtocol.java (12)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/TakerBotProtocol.java (5)
    M cli/src/main/java/bisq/cli/CliMain.java (5)
    D cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (81)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (87)
    D cli/src/main/java/bisq/cli/DirectionFormat.java (61)
    M cli/src/main/java/bisq/cli/GrpcClient.java (14)
    D cli/src/main/java/bisq/cli/OfferFormat.java (309)
    D cli/src/main/java/bisq/cli/TableFormat.java (156)
    D cli/src/main/java/bisq/cli/TradeFormat.java (222)
    D cli/src/main/java/bisq/cli/TransactionFormat.java (60)
    M cli/src/main/java/bisq/cli/opts/EditOfferOptionParser.java (4)
    M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (46)
    M cli/src/main/java/bisq/cli/table/builder/AbstractTableBuilder.java (9)
    M cli/src/main/java/bisq/cli/table/builder/OfferTableBuilder.java (80)
    M cli/src/main/java/bisq/cli/table/column/AltcoinColumn.java (2)
    M cli/src/main/java/bisq/cli/table/column/FiatColumn.java (2)
    M cli/src/test/java/bisq/cli/table/AddressCliOutputDiffTest.java (17)
    M cli/src/test/java/bisq/cli/table/GetBalanceCliOutputDiffTest.java (15)
    M cli/src/test/java/bisq/cli/table/GetOffersCliOutputDiffTest.java (9)
    M cli/src/test/java/bisq/cli/table/GetTradeCliOutputDiffTest.java (9)
    M cli/src/test/java/bisq/cli/table/GetTransactionCliOutputDiffTest.java (10)
    M cli/src/test/java/bisq/cli/table/PaymentAccountsCliOutputDiffTest.java (9)
    M core/src/main/java/bisq/core/api/CoreApi.java (12)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (19)
    M core/src/main/java/bisq/core/api/EditOfferValidator.java (21)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (40)
    M core/src/main/java/bisq/core/api/model/builder/OfferInfoBuilder.java (16)
    M proto/src/main/proto/grpc.proto (230)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6060.patch
https://github.com/bisq-network/bisq/pull/6060.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6060
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6060 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220218/cc784bc3/attachment-0001.htm>