[bisq-network/bisq] [1.8.3 fix] Get payment method ID from offerPayload (PR #6069)

[jmacxx]

Fixes bug related to privacy enhancement in 1.8.3.

Was getting an NPE viewing closed trades older than v1.7.0.
makerPaymentMethodId is null for older trades.
makerPaymentAccountPayload can be null for trades where we have removed account info for privacy reasons (see #6001).
The payment method ID can always be obtained from offerPayload.


---

To reproduce: 

- Enable the privacy setting "Clear sensitive data after (days)"
- Restart Bisq for the change to have effect
- Open trade details of a trade done prior to July 2021.
- Error shown.  Closed trades lost.
- Need to restore from backup.
 

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6069

-- Commit Summary --

  * Get payment method ID from offerPayload.

-- File Changes --

    M core/src/main/java/bisq/core/trade/model/bisq_v1/Contract.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6069.patch
https://github.com/bisq-network/bisq/pull/6069.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6069
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6069 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220221/64e6bc99/attachment-0001.htm>