[bisq-network/bisq] Fix trade fee validation bug (PR #5949)

[jmacxx]

A support issue identified a bug in the trade fee validation when two BSQ UTXOs are burned to pay the fee.

- This PR addresses the issue by checking if the expected fee is larger than the first UTXO value.
- A new test has been added to validate this.
- Other tests have been updated as a result of the changes in https://github.com/bisq-network/bisq/pull/5826 where fee parameter is now supplied from a filter; this results in more accurate fee checking.


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5949

-- Commit Summary --

  * Fix trade fee validation bug when two BSQ UTXOs used to pay the fee.

-- File Changes --

    M core/src/main/java/bisq/core/provider/mempool/TxValidator.java (7)
    M core/src/test/java/bisq/core/provider/mempool/TxValidatorTest.java (49)
    M core/src/test/resources/bisq/core/provider/mempool/badOfferTestData.json (3)
    M core/src/test/resources/bisq/core/provider/mempool/offerTestData.json (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5949.patch
https://github.com/bisq-network/bisq/pull/5949.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5949
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5949 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220103/d1ffbeee/attachment-0001.htm>