[bisq-network/bisq] Rename API method keepfunds -> closetrade (PR #5951)

[Stan]

Trade proceeds and deposits have already been transferred to Bisq wallets before the `keepfunds` command is (was) executed;  `keepfunds` merely moves open trade to closed trade lists and persistence files.  Renaming `keepfunds` as `closetrade` makes its purpose clear to API users.

The commit modifies only method names and comments in api server+cli classes, apitest cases, and api trade simulation scripts.

Based on `master`

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5951

-- Commit Summary --

  * Rename API method keepfunds -> closetrade

-- File Changes --

    M apitest/scripts/trade-simulation-utils.sh (16)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyXMROfferTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (9)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellXMROfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/bot/BotClient.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/BotProtocol.java (8)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/MakerBotProtocol.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/ProtocolStep.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/TakerBotProtocol.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/bot/script/BashScriptGenerator.java (4)
    M cli/src/main/java/bisq/cli/CliMain.java (10)
    M cli/src/main/java/bisq/cli/GrpcClient.java (4)
    M cli/src/main/java/bisq/cli/Method.java (2)
    M cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (8)
    M core/src/main/java/bisq/core/api/CoreApi.java (4)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (4)
    A core/src/main/resources/help/closetrade-help.txt (29)
    D core/src/main/resources/help/keepfunds-help.txt (31)
    M core/src/main/resources/help/withdrawfunds-help.txt (14)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (15)
    M proto/src/main/proto/grpc.proto (6)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5951.patch
https://github.com/bisq-network/bisq/pull/5951.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5951
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5951 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220105/2b915562/attachment.htm>