[bisq-network/bisq] Feature enabling log file upload to mediators (PR #5953)
jmacxx
notifications at github.com
Thu Jan 6 19:37:37 CET 2022
Closes #5906
@pazza asked for the process of submitting log files to be made easier. The solution presented here is basically a click and send option to transmit appropriate log files to a dispute's Mediator.
- From dispute chat there is a button `Send Log Files`.
- A popup is shown explaining the procedure with a progress bar.
- User presses `Send`.
- Logs which reference the tradeId are packaged in a zip file.
- The zip file is sent to the Mediator.
- User is notified that the upload is complete, or if there was an error.
- A message in dispute chat alerts the Mediator that log files have been received.
---
### Screenshots:
**Mediator notification:**
**Mediator's received logs:**
---
**Implementation notes:**
- Log files (even compressed) are larger than the max network packet size, so the file is transmitted in a series of blocks, each ack'd by the receiver and assembled into the received zip file.
- The zip file is named with the tradeId, the trader's role and a datestamp. This makes it easier to organize received files.
- Within the zip, logs are created under a subdirectory named with the tradeId and trader's role; again this is to make it easier to organize the logs when support personnel extract them from the zip.
**Testing notes:**
- In regtest, there are mediator and trader sessions. Start a trade, open a dispute, go to dispute chat and press [send logs].
- Tested in Tor/mainnet environment by modifying the code to send logs to an alternate onion address.
- The zip file handling code may have unforseen issues on different platforms. I have yet to verify in Windows or MacOS.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5953
-- Commit Summary --
* Feature enabling log file upload to mediators
-- File Changes --
M common/src/main/java/bisq/common/file/FileUtil.java (12)
M core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (3)
M core/src/main/java/bisq/core/support/dispute/Dispute.java (27)
M core/src/main/java/bisq/core/support/dispute/DisputeManager.java (18)
A core/src/main/java/bisq/core/support/dispute/mediation/FileTransferReceiver.java (109)
A core/src/main/java/bisq/core/support/dispute/mediation/FileTransferSender.java (160)
A core/src/main/java/bisq/core/support/dispute/mediation/FileTransferSession.java (151)
M core/src/main/java/bisq/core/support/dispute/mediation/MediationManager.java (62)
M core/src/main/resources/i18n/displayStrings.properties (16)
A core/src/test/java/bisq/core/support/dispute/mediation/FileTransferSessionTest.java (207)
A desktop/src/main/java/bisq/desktop/main/overlays/windows/SendLogFilesWindow.java (245)
M desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeChatPopup.java (18)
M desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeView.java (18)
M p2p/src/main/java/bisq/network/p2p/AckMessageSourceType.java (3)
A p2p/src/main/java/bisq/network/p2p/FileTransferPart.java (106)
M proto/src/main/proto/pb.proto (11)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5953.patch
https://github.com/bisq-network/bisq/pull/5953.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5953
You are receiving this because you are subscribed to this thread.
Message ID: <bisq-network/bisq/pull/5953 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220106/691a5f8f/attachment.htm>
More information about the bisq-github
mailing list