[bisq-network/bisq] Wording for Bsq swap cancellation popups & withdrawal prompt (PR #5957)

[jmacxx]

Fixes #5956

- This PR addresses two issues raised by #5956 
- Additionally fixes a related issue when canceling a Bsq Swap from Market View it was mentioning losing 0.00 maker fee.
- Additionally, when an offer being cancelled, refer to it as "this offer" instead of "that offer".


---


### 1

After cancelling a Bsq Swap do not show the "Withdraw to wallet" prompt as it is unnecessary.






### 2

<details>
  <summary>Withdrawal prompt reworded to avoid confusion (click for details)</summary>

**Pre**
![wording_change_normal_offer_pre](https://user-images.githubusercontent.com/47253594/148573077-16dfe982-5ac0-4b75-8648-83c770a221c8.png)

**Post**
![wording_change_normal_offer_post](https://user-images.githubusercontent.com/47253594/148573087-0b06a40b-ea36-4578-9b33-2f4a4dc559a3.png)

</details>





### 3


<details>
  <summary>Bsq Swap canceled from Market View -> remove reference to maker fee. (click for details)</summary>

**Pre**
![remove_no_fee_offer_pre](https://user-images.githubusercontent.com/47253594/148573011-0d2f899a-e86e-42ba-99f3-b4679a348ccc.png)

**Post**
![remove_no_fee_offer_post](https://user-images.githubusercontent.com/47253594/148573049-418d0c0c-b706-46b3-8b79-f886530f0459.png)

</details>


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5957

-- Commit Summary --

  * Wording for Bsq swap cancellation popups & withdrawal prompt

-- File Changes --

    M core/src/main/resources/i18n/displayStrings.properties (7)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersView.java (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5957.patch
https://github.com/bisq-network/bisq/pull/5957.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5957
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5957 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220107/8f048235/attachment.htm>