[bisq-network/bisq] Add API methods 'failtrade', 'unfailtrade' + test case (#2) (PR #5961)

[Stan]

Prerequisite for next PR:  **Add API method `gettrades`.**

The `gettrades` method implementation will show 'open', 'closed', and 'failed' trades.  Users already needed to be able to fail and unfail trades for the same reasons they do in the UI, and `apitest` cases will need to be able to fail and unfail trades to check correct behavior of the `gettrades` method.


Based on https://github.com/bisq-network/bisq/pull/5951

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5961

-- Commit Summary --

  * Rename API method keepfunds -> closetrade
  * Adjust api beta test guide to new closetrade cmd
  * Add API methods 'failtrade', 'unfailtrade'

-- File Changes --

    M apitest/docs/api-beta-test-guide.md (10)
    M apitest/scripts/trade-simulation-utils.sh (16)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (3)
    A apitest/src/test/java/bisq/apitest/method/trade/FailUnfailTradeTest.java (143)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyXMROfferTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (9)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellXMROfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (11)
    M apitest/src/test/java/bisq/apitest/scenario/bot/BotClient.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/BotProtocol.java (8)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/MakerBotProtocol.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/ProtocolStep.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/TakerBotProtocol.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/bot/script/BashScriptGenerator.java (4)
    M cli/src/main/java/bisq/cli/CliMain.java (36)
    M cli/src/main/java/bisq/cli/GrpcClient.java (12)
    M cli/src/main/java/bisq/cli/Method.java (4)
    M cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (26)
    M core/src/main/java/bisq/core/api/CoreApi.java (12)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (65)
    M core/src/main/java/bisq/core/trade/bisq_v1/FailedTradesManager.java (74)
    A core/src/main/resources/help/closetrade-help.txt (29)
    A core/src/main/resources/help/failtrade-help.txt (28)
    D core/src/main/resources/help/keepfunds-help.txt (31)
    A core/src/main/resources/help/unfailtrade-help.txt (32)
    M core/src/main/resources/help/withdrawfunds-help.txt (14)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (45)
    M proto/src/main/proto/grpc.proto (24)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5961.patch
https://github.com/bisq-network/bisq/pull/5961.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5961
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5961 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220107/c7456216/attachment-0001.htm>