[bisq-network/bisq] Edit offer button (PR #5955)

xyzmaker123 notifications at github.com
Sat Jan 8 12:37:57 CET 2022


@xyzmaker123 commented on this pull request.



> @@ -138,6 +143,7 @@ private void onEditOpenOfferRemoved() {
             editOfferView = null;
         }
 
+        // navigation.navigateToPreviousVisitedView();

I think it would be nice to return to Offer Book here. Unfortunately this method didn't worked as expected - it moves me to Portfolio -> History. I'll try to debug why `previousPath` is calculated as `ClosedTradesView`  [here](https://github.com/bisq-network/bisq/blob/7f73df5dfd761a26392fb6ae16adc937ef6bf9da/desktop/src/main/java/bisq/desktop/Navigation.java#L111-L139) when I [click](https://github.com/xyzmaker123/bisq/blob/0ab0aed79ab2d8762be935ea77330ba693d62bad/desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java#L737-L739) edit button. Any tips in the meantime are welcomed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5955#pullrequestreview-847147930
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5955/review/847147930 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220108/4d9dc97a/attachment.htm>


More information about the bisq-github mailing list