[bisq-network/bisq] Edit offer button (PR #5955)
Christoph Atteneder
notifications at github.com
Tue Jan 11 13:04:39 CET 2022
@ripcurlx approved this pull request.
ACK - please see my comments what I changed.
> @@ -138,6 +143,7 @@ private void onEditOpenOfferRemoved() {
editOfferView = null;
}
+ // navigation.navigateToPreviousVisitedView();
Please remove unused code
> + if (data instanceof Offer) {
+ Offer offer = (Offer) data;
+ openOffer = openOfferManager.getOpenOfferById(offer.getId()).orElse(null);
+ }
I'd rather do this in the OfferBookViewModel
--
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5955#pullrequestreview-849069676
You are receiving this because you are subscribed to this thread.
Message ID: <bisq-network/bisq/pull/5955/review/849069676 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220111/8a7381b5/attachment.htm>
More information about the bisq-github
mailing list