[bisq-network/bisq] Tor bridges preferences fix (PR #5966)

[jmacxx]

Fixes 5937

- Postpone accessing preferences BridgeAddressProvider until needed by Tor.  Previously they would be accessed too early when preferences had not yet been read from disk.  Now we access them when Tor is started.


- Force persistence write when editing Tor Bridge settings.  This is necessary because Tor settings are edited before the app has completed startup and normally persistence is prohibited.
 

---

With this change it is possible to use Tor bridges when Bisq refuses to start with the default settings.  A button to edit the Tor settings is shown after the startup times-out allowing Tor bridges to be chosen and to restart Bisq with the new settings.  

![image](https://user-images.githubusercontent.com/47253594/149672072-2f732b16-df50-4c26-8abe-ffba5d2f9000.png)


After choosing Tor bridges, the setting will be used at next startup:

    INFO  b.network.p2p.network.NewTor: Using bridges: obfs4 154.35.22.10:15937 

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5966

-- Commit Summary --

  * Postpone accessing preferences BridgeAddressProvider until needed by Tor.
  * Force persistence write when editing Tor Bridge settings.

-- File Changes --

    M common/src/main/java/bisq/common/persistence/PersistenceManager.java (18)
    M core/src/main/java/bisq/core/user/Preferences.java (8)
    M p2p/src/main/java/bisq/network/p2p/NetworkNodeProvider.java (2)
    M p2p/src/main/java/bisq/network/p2p/network/NewTor.java (7)
    M p2p/src/test/java/bisq/network/p2p/network/TorNetworkNodeTest.java (13)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5966.patch
https://github.com/bisq-network/bisq/pull/5966.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5966
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5966 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220116/46ce9a8c/attachment.htm>