[bisq-network/bisq] [WIP] Add API 'gettrades' method (PR #5976)

Stan notifications at github.com
Tue Jan 18 17:06:19 CET 2022



Based on `master`.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5976

-- Commit Summary --

  * Add GetTrades proto message, + needed TradeInfo fields
  * Add GrpcTradesService.getTrades service method
  * Add List<Trade> getTrades() to FailedTradesManager (w/out transitive jfx dep)
  * Add List<Trade> getTrades() to TradeManager (w/out transitive jfx dep)
  * Add List<OpenOffer> getCanceledOpenOffers() ClosedTradableManager
  * Add buyer/seller dep & status-desc fields to TradeInfoV1Builder
  * Add buyer/seller dep & status-desc fields to TradeInfo
  * Remove commented code
  * Add server impl for gettrades (open|closed), refactor getrole methods
  * Format gettrades CLI outout
  * Support gRPC gettrades call in CLI
  * Try to display accurate status of closed trades, or "Pending" if still open
  * Re-set log level to INFO in apitest cases

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (14)
    M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTest.java (9)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (5)
    M apitest/src/test/java/bisq/apitest/scenario/LongRunningTradesTest.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (2)
    M cli/src/main/java/bisq/cli/CliMain.java (25)
    M cli/src/main/java/bisq/cli/GrpcClient.java (9)
    M cli/src/main/java/bisq/cli/Method.java (1)
    A cli/src/main/java/bisq/cli/opts/GetTradesOptionParser.java (84)
    M cli/src/main/java/bisq/cli/opts/OptLabel.java (1)
    M cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (22)
    M cli/src/main/java/bisq/cli/table/builder/AbstractTradeListBuilder.java (4)
    A cli/src/main/java/bisq/cli/table/builder/ClosedTradeTableBuilder.java (61)
    M cli/src/main/java/bisq/cli/table/builder/FailedTradeTableBuilder.java (8)
    M cli/src/main/java/bisq/cli/table/builder/OpenTradeTableBuilder.java (4)
    M cli/src/main/java/bisq/cli/table/builder/TableBuilder.java (12)
    M cli/src/main/java/bisq/cli/table/builder/TableType.java (6)
    M cli/src/main/java/bisq/cli/table/builder/TradeTableColumnSupplier.java (12)
    A cli/src/test/java/bisq/cli/GetTradesSmokeTest.java (52)
    M core/src/main/java/bisq/core/api/CoreApi.java (24)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (57)
    A core/src/main/java/bisq/core/api/model/CanceledTradeInfo.java (57)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (45)
    M core/src/main/java/bisq/core/api/model/builder/TradeInfoV1Builder.java (19)
    M core/src/main/java/bisq/core/trade/ClosedTradableFormatter.java (8)
    M core/src/main/java/bisq/core/trade/ClosedTradableManager.java (9)
    M core/src/main/java/bisq/core/trade/TradeManager.java (7)
    M core/src/main/java/bisq/core/trade/bisq_v1/FailedTradesManager.java (5)
    A core/src/main/resources/help/gettrades-help.txt (27)
    M core/src/main/resources/i18n/displayStrings.properties (1)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (88)
    M proto/src/main/proto/grpc.proto (23)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5976.patch
https://github.com/bisq-network/bisq/pull/5976.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5976
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5976 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220118/643db4a2/attachment.htm>


More information about the bisq-github mailing list