[bisq-network/bisq] Negative "Below % from market price" + "Deactivate offer if" doesn't work in some situation (Issue #5979)

[Liisachan]

Let's say the current market price is 40000 and you are making an offer to buy BTC, with a negative "Below % from market price", say -10% for simplicity, meaning you are willing to pay 10% *more* than the market price for some (possibly unusual) reason, i.e. you're fine with the rate 44000. It would be reasonable for you to think, "But any rate higher than 45100 will be too expensive."

In this situation, you should be able to set the "Deactivate offer if market price is above" = 41000, since 45100 is 110% of 41000. That is to say, you're willing to pay 10% more but only if the market price stays below 41000; you want your offer to be disabled if the market price becomes 41000 or higher (when you'd have to pay 45100 or higher).

However, Bisq doesn't seem to let you do this, showing an error message which looks like: "Value must be higher than 44000."
It is indeed a bit counter-intuitive that the offer should be deactivated at 41000 when you're making a new offer at 44000 - apparently already *higher* than your limit. But with a negative deviation, this 41000 (a possible future market price) actually means 45100 (a price you'd have to then pay).

One might think -10% is unrealistic but the values above are simplified just to illustrate the issue. A similar problem can happen in various realistic situations, where you're willing to (or you have no other choice but to) pay a slightly higher price than the market price. 

Correct me if I'm misunderstanding something, as how these parameters are supposed to interact is somewhat confusing when the deviation is negative.

#### Version
1.8.0

### Steps to reproduce
Not 100% sure, but...
(1) Try to make an offer, with a negative value B for "Below % from market price", e.g. -5%, -10%, etc.
(2) Let M be the current Market price, and N be the price at which a New offer will be made: N = M(1 - B/100) > M with B < 0. Try to use the "Deactivate offer if" value D greater than M but less than N.

### Expected behaviour
A new offer will be made with the initial deviation B (negative), and with the "Deactivate offer if" value D. Note that although D is already less than N, it is greater than the current market price M.

### Actual behaviour
A new offer is not made, refused with an error message "Value must be higher than N".

### PS
https://bisq.community/ is still using v2 onion http://dnkeu7zlmu7vlyox.onion/ which is no longer supported by the current version of Tor. A new Tor Browser user, who doesn't know the situation, may be scared to see the error message from the browser. To avoid various potential problems and confusion, I'd suggest a v3-onion option or no-onion option at all for https://bisq.community/

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5979
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/issues/5979 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220118/bb3d4e92/attachment.htm>