[bisq-network/bisq] Prevent reset offer values after switch to same currency payment account (PR #5983)

xyzmaker123 notifications at github.com
Fri Jan 21 12:54:20 CET 2022


I agree code around `MutableOfferView` is quite complex. When I was debugging [original issue](https://github.com/bisq-network/bisq/issues/5973) I set debugger breakpoint on [`updateButtonDisableState`](https://github.com/bisq-network/bisq/blob/d901faa29e88df81448e74bd16732c87646ec6bf/desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferViewModel.java#L1297) method and I saw it was invoked 5 or 6 times after changing trading account (in ideal world there should be single call).

Sure - I'll try to prepare testing scenarios that covers changes in this pull request. If you see any edge cases that I should include don't hesitate to share them here. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5983#issuecomment-1018439817
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5983/c1018439817 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220121/7b01cee1/attachment.htm>


More information about the bisq-github mailing list