[bisq-network/bisq] Add missing filtering on lists (PR #5963)

xyzmaker123 notifications at github.com
Tue Jan 25 14:34:15 CET 2022


@xyzmaker123 commented on this pull request.



>                  return columns;
             };
 
             GUIUtil.exportCSV("bsqSwapHistory.csv", headerConverter, contentConverter,
-                    new UnconfirmedBsqSwapsListItem(), sortedList, (Stage) root.getScene().getWindow());
+                    null, sortedList, (Stage) root.getScene().getWindow());

It is passed into [`headerConverter`](https://github.com/xyzmaker123/bisq/blob/9e753458e4e248ac9b0852e05112b79c9dac42c1/desktop/src/main/java/bisq/desktop/util/GUIUtil.java#L330), but `headerConverter` doesn't use it, so passing null doesn't breaks anything. I think we could refactor `exportCSV` a bit deeper - I was planning to do it in dedicated pr. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5963#discussion_r791714713
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5963/review/862284096 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220125/7366b22f/attachment.htm>


More information about the bisq-github mailing list