[bisq-network/bisq] Add API 'gettrades' method (PR #5976)

Stan notifications at github.com
Tue Jan 25 22:24:53 CET 2022


@ghubstan commented on this pull request.



> +            stream(CATEGORY.values()).anyMatch(v -> v.name().equalsIgnoreCase(c));
+
+    public GetTradesOptionParser(String[] args) {
+        super(args);
+    }
+
+    public GetTradesOptionParser parse() {
+        super.parse();
+
+        // Short circuit opt validation if user just wants help.
+        if (options.has(helpOpt))
+            return this;
+
+        if (options.has(categoryOpt)) {
+            String category = options.valueOf(categoryOpt);
+            if (category.isEmpty())

The block catches the empty param value, i.e.,  `--category=`, so it's not dead.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5976#discussion_r792131246
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5976/review/862881613 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220125/e6af6075/attachment.htm>


More information about the bisq-github mailing list