[bisq-network/bisq] Add API 'gettrades' method (PR #5976)

Stan notifications at github.com
Tue Jan 25 23:06:04 CET 2022


@ghubstan commented on this pull request.



> @@ -206,12 +214,19 @@ protected void validate() {
                     ? formatToPercent(t.getOffer().getMarketPriceMargin())

The `cli` module cannot use (depend on) anything in the `core` module.  Everything between `cli` and `daemon` is limited to grpc/protobuf requests & responses, and this forces some duplication.  We'll try to minimize the need to duplicate anything in Bisq2.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5976#discussion_r792158764
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5976/review/862917782 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220125/c91f3a24/attachment.htm>


More information about the bisq-github mailing list