[bisq-network/bisq] Add API 'gettrades' method (PR #5976)

[xyzmaker123]

@xyzmaker123 commented on this pull request.



> +            stream(CATEGORY.values()).anyMatch(v -> v.name().equalsIgnoreCase(c));
+
+    public GetTradesOptionParser(String[] args) {
+        super(args);
+    }
+
+    public GetTradesOptionParser parse() {
+        super.parse();
+
+        // Short circuit opt validation if user just wants help.
+        if (options.has(helpOpt))
+            return this;
+
+        if (options.has(categoryOpt)) {
+            String category = options.valueOf(categoryOpt);
+            if (category.isEmpty())

Didn't tested it but I believe `isValidCategory.test(category)` should catch this scenario

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5976#discussion_r792463407
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5976/review/863308567 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220126/4e68b141/attachment.htm>