[bisq-network/bisq] Add API 'gettrades' method (PR #5976)

Stan notifications at github.com
Thu Jan 27 21:41:40 CET 2022


@ghubstan commented on this pull request.



> @@ -292,7 +298,10 @@ Trade getTrade(String tradeId) {
     List<TradeModel> getOpenTrades() {
         coreWalletsService.verifyWalletsAreAvailable();
         coreWalletsService.verifyEncryptedWalletIsUnlocked();
-        return tradeManager.getTrades().stream().map(t -> (TradeModel) t).collect(Collectors.toList());
+        return tradeManager.getTrades().stream()
+                .map(t -> (TradeModel) t)

I removed two casts in https://github.com/bisq-network/bisq/pull/5976/commits/820642516a64ed85b0b365dc8c22305d45c54951, but the mapping in line 303 had to stay.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5976#discussion_r793982285
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5976/review/865405058 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220127/9ae2b763/attachment.htm>


More information about the bisq-github mailing list