[bisq-network/bisq] Clear payment account payload info from closed trades. (PR #6001)

jmacxx notifications at github.com
Sat Jan 29 04:39:33 CET 2022


Answering your questions @pazza83 :

> just checking trades in mediation and arbitration will not count as completed trades?
> Assuming mediated trades are completed once payout occurs.

Correct, only trades that are Closed are considered.

> What about arbitrated trades? What point do these become completed after payment is made to donation address?

Same, they transition to Closed once the arbitration ticket has been closed.

> Also just wondering how this would affect how a duplicate offer creation when a previous offer has had their payload info removed?

No effect as offers do not contain account payloads or contracts, only trades do.  

---

There's some work remaining to sanitize account payloads from closed dispute tickets which looks like the implementation will need refactoring, so moving this back into draft for a couple of days.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6001#issuecomment-1024823755
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6001/c1024823755 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220128/161968f4/attachment-0001.htm>


More information about the bisq-github mailing list