[bisq-network/bisq] Move get (cryptocurrency) offer filter to daemon (PR #6086)

[Stan]

Some API reference & Python bot examples exposed an API bug the Java CLI has been hiding. Due due this Bisq v1 `Offer` entity design:

- In fiat offers, the `baseCurrencyCode`=BTC, `counterCurrencyCode`=FiatCode
- In altcoin offers, `baseCurrencyCode`=AltcoinCode, `counterCurrencyCode`=BTC,

new API examples were not doing what the CLI has been doing for several months, which is get (cryptocurrency) all BTC offers from the server, and filter on the altcoin code.  The CLI side filtering should have been done on the server, as it is in this commit.

A lot of dead gRPC client side offer filtering code is removed as well.

Based on `master`.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6086

-- Commit Summary --

  * Move get (cryptocurrency) offer filter to daemon

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateXMROffersTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/trade/FailUnfailTradeTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyXMROfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellXMROfferTest.java (4)
    M cli/src/main/java/bisq/cli/GrpcClient.java (45)
    M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (72)
    M cli/src/test/java/bisq/cli/AbstractCliTest.java (2)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (61)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (7)
    M core/src/main/java/bisq/core/locale/CurrencyUtil.java (13)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6086.patch
https://github.com/bisq-network/bisq/pull/6086.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6086
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6086 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220303/9ee25c54/attachment-0001.htm>