[bisq-network/bisq] API bug-fix for incorrect BsqSwap's OfferInfo.isActivated value [No. 3] (PR #6094)

[Stan]

I think this bug was introduced when deprecating `GrpcOffersService.getMyOffer(id)`, in favor of using only `getOffer(id)` for 'my' and 'available' offers.  This change explicitly sets the proto's `isActivated` flag in the `OfferInfo` factory methods, and adds checks to api offer test cases.
    
Based on branch `2-improve-grpc-exception-status-code-mapping`, PR https://github.com/bisq-network/bisq/pull/6088

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/6094

-- Commit Summary --

  * Move get (cryptocurrency) offer filter to daemon
  * Force rebuild after github action ECONNRESET
  * Send meaningful io.grpc.Status.Code to gRPC clients
  * Fix comment
  * Make codacy happy
  * Fix API OfferInfo.isActivated setting for bsqswaps

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateXMROffersTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapBuyBtcTradeTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapSellBtcTradeTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/trade/FailUnfailTradeTest.java (20)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyXMROfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellXMROfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/wallet/BtcTxFeeRateTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/wallet/WalletProtectionTest.java (12)
    M cli/src/main/java/bisq/cli/CliMain.java (3)
    M cli/src/main/java/bisq/cli/GrpcClient.java (45)
    M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (72)
    M cli/src/test/java/bisq/cli/AbstractCliTest.java (2)
    M core/src/main/java/bisq/core/api/CoreDisputeAgentsService.java (9)
    M core/src/main/java/bisq/core/api/CoreHelpService.java (4)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (74)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (7)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (11)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (68)
    M core/src/main/java/bisq/core/api/EditOfferValidator.java (9)
    A core/src/main/java/bisq/core/api/exception/AlreadyExistsException.java (31)
    A core/src/main/java/bisq/core/api/exception/FailedPreconditionException.java (32)
    A core/src/main/java/bisq/core/api/exception/NotAvailableException.java (31)
    A core/src/main/java/bisq/core/api/exception/NotFoundException.java (33)
    A core/src/main/java/bisq/core/api/exception/package-info.java (29)
    M core/src/main/java/bisq/core/api/model/CanceledTradeInfo.java (4)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (21)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (4)
    M core/src/main/java/bisq/core/locale/CurrencyUtil.java (13)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcExceptionHandler.java (62)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (14)
    M daemon/src/main/java/bisq/daemon/grpc/interceptor/GrpcServiceRateMeteringConfig.java (6)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/6094.patch
https://github.com/bisq-network/bisq/pull/6094.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6094
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/6094 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220307/5345e9e4/attachment.htm>