[bisq-network/bisq] Unsynced DAO state forcing to restart Bisq in order to fix sync (Issue #6073)

[Christoph Atteneder]

> One reproducable error came to light from a user experiencing an issue in the support channel. Installing bisq as a new user about 6 weeks after the latest release will consistently produce a DAO state which is out of consensus. Steps to reproduce:
> 
> * Delete the local/share/Bisq directory (i.e. starting with a completely empty data directory).
> * Run the Bisq release from the previous month (at the time of writing, v1.8.2).
> * 6000 BsqBlocks are received from the seednode advancing the height from 719240 to 725240.
> * No subsequent request for BsqBlocks is made, and the chain remains un-synced indefinitely.
> 
> This is due to [L237](https://github.com/bisq-network/bisq/blob/c6293b52730e59c675953fc8cff9238d0efd7edc/core/src/main/java/bisq/core/dao/node/lite/LiteNode.java#L237) in LiteNode.java which does not request subsequent blocks if the BitcoinJ chain is still downloading.
> 
> If you allow the BitcoinJ chain to complete its sync and then perform the same test a different error presents itself:
> 
> * With a fully synced wallet, stop Bisq and delete the `Bisq/btc_mainnet/db` directory.
> * Run the Bisq release from the previous month (at the time of writing, v1.8.2).
> * 6000 BsqBlocks are received from the seednode advancing the height from 719240 to 725240.
> * The remainder of the BsqBlocks are requested and received advancing the height to current.
> * Lots of red warnings appear in the log when processing the BsqBlocks.
> * The DAO network status indicates it is out of sync with seednodes and needs to be rebuilt.
> 
> The errors seem to indicate that the `BlindVoteStore` data file received from the seednode is missing data.
> 
> ```
> We have a blindVoteTx but we do not have the corresponding blindVote payload
> We could not find a list which matches the majority so we cannot calculate the vote result. Please restart and resync the DAO state.
> ```
> 
> I think this may be that the seednode had to truncate the `GetDataResponse` payload due to too many AccountAgeWitness and/or BlindVotePayload records.
> 
> 1552038 bytes : BlindVoteStore size first time 1595935 bytes : BlindVoteStore size second and subsequent times.
> 
> The same error can be produced without deleting the whole data directory, just AccountAgeWitness and BlindVotePayload.

And it doesn't matter how often you restart the node to get everything in-sync?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/6073#issuecomment-1066503340
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/issues/6073/1066503340 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220314/6278b323/attachment-0001.htm>