[bisq-network/bisq] Separate transaction details in funds views (PR #6110)
xyzmaker123
notifications at github.com
Thu Mar 17 16:53:59 CET 2022
Fixes #5308
Reserved view:
![01-reserved-funds](https://user-images.githubusercontent.com/84982606/158839739-503cbb01-4a36-44ad-8dc5-41fbc4fbbd95.png)
Locked view:
![02-locked-funds](https://user-images.githubusercontent.com/84982606/158839761-2b7cee22-76ed-4c05-90ba-11a394db68ef.png)
Transactions:
![03-transactions](https://user-images.githubusercontent.com/84982606/158839772-24cd366e-481c-4e44-8c6b-8d70373ec0ef.png)
A few questions / doubts:
- should I show short Id or full Id in list?
- is columns order proper?
- there is no always tradeId available in transactions, but txId - should I show it and maybe use different column name?
- transactions list is crowded - maybe remove some columns (f.x. Transaction Id)?
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/6110
-- Commit Summary --
* Reserved view - Offer ID column
* Reserved view - fix address column alignment
* Locked view - Trade ID column
* Transactions View - Trade ID column
-- File Changes --
M core/src/main/resources/i18n/displayStrings.properties (26)
M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedListItem.java (2)
M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedView.fxml (5)
M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedView.java (50)
M desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedListItem.java (2)
M desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.fxml (5)
M desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.java (47)
M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsListItem.java (30)
M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.fxml (7)
M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java (72)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/6110.patch
https://github.com/bisq-network/bisq/pull/6110.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6110
You are receiving this because you are subscribed to this thread.
Message ID: <bisq-network/bisq/pull/6110 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220317/bb97589f/attachment.htm>
More information about the bisq-github
mailing list