[bisq-network/bisq] Update trigger price validation (PR #6109)
Christoph Atteneder
notifications at github.com
Mon Mar 21 11:27:35 CET 2022
@ripcurlx commented on this pull request.
> @@ -72,7 +72,8 @@ public static MonetaryValidator getPriceValidator(boolean isFiatCurrency) {
}
public static InputValidator.ValidationResult isTriggerPriceValid(String triggerPriceAsString,
- Price price,
I'd rather use the MarketPrice object exposing the currencyCode property instead of adding another parameter. WDYT?
--
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6109#pullrequestreview-915518754
You are receiving this because you are subscribed to this thread.
Message ID: <bisq-network/bisq/pull/6109/review/915518754 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220321/d5f83802/attachment.htm>
More information about the bisq-github
mailing list