[bisq-network/compensation] For Cycle 34 (Issue #1033)
Stan
notifications at github.com
Thu Mar 24 13:28:47 CET 2022
<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.
See the following link for details:
https://bisq.wiki/Making_a_compensation_request
Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->
## Summary
> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_
- **BSQ requested**: **`10365.85`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: 12750 <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 1.23 USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #1008 <!-- Link to last compensation request submitted -->
## Contributions delivered
> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._
| Title | Team | USD | Link | Notes |
| --- | --- | ---: | --- | --- |
| Add API 'gettrades' method | dev | 3000 | https://github.com/bisq-network/bisq/pull/5976 | merged, approved in cycle 33 |
| Modify .proto file comments to be parsed by bisq-grpc-api-doc [No. 1] | dev | 100 | https://github.com/bisq-network/bisq/pull/6042 | merged, approved in cycle 33 |
| Fix API FeeService NPE | dev | 50 | https://github.com/bisq-network/bisq/pull/6052 | merged, approved in cycle 33 |
| Fix BSQ swap description of BTC price for 1 BSQ | dev | 0 | https://github.com/bisq-network/bisq/pull/6074 | merged |
| Prepare API Offers .proto defs for significant changes [No. 1] | dev | | https://github.com/bisq-network/bisq/pull/6055 | merged |
| Change API's OfferInfo proto's price field to string [No. 2] | dev | | https://github.com/bisq-network/bisq/pull/6056 | merged |
| Change API grpc.proto triggerPrice field to string [No. 3] | dev | | https://github.com/bisq-network/bisq/pull/6057 | merged |
| Change API OfferInfo volume/minVolume proto fields to string [No. 4] | dev | | https://github.com/bisq-network/bisq/pull/6060 | merged |
| Change TradeInfo proto's tradePrice & tradeVolume fields to string [No. 5] | dev | | https://github.com/bisq-network/bisq/pull/6062 | merged |
| Clarify meaning of API/Offer related % fields [No. 6] | dev | | https://github.com/bisq-network/bisq/pull/6065 | merged |
| Continue documenting grpc.proto for API reference site [No. 7] | dev | | https://github.com/bisq-network/bisq/pull/6068 | merged |
| Remove GetTradeStatistics service from grpc.proto [No. 8] | dev | | https://github.com/bisq-network/bisq/pull/6079 | merged |
| Convert grpc.proto field names to snake_case [No. 9] | dev | | https://github.com/bisq-network/bisq/pull/6080 | merged |
| Fix 3 misleading .proto TradeInfo field names [No. 10] | dev | | https://github.com/bisq-network/bisq/pull/6081 | merged |
| Move get (cryptocurrency) offer filter to daemon [No. 1] | dev | | https://github.com/bisq-network/bisq/pull/6086 | merged |
| Send meaningful io.grpc.Status.Code to gRPC clients [No. 2] | dev | | https://github.com/bisq-network/bisq/pull/6088 | merged |
| API bug-fix for incorrect BsqSwap's OfferInfo.isActivated value [No. 3] | dev | | https://github.com/bisq-network/bisq/pull/6094 | merged |
| Generate API Reference markdown, implement API cli/java/python examples | dev | 9000 | https://github.com/ghubstan/bisq-api-reference | generates API reference + examples |
| Deploy API Reference site with cli/java/python examples + python bot examples | dev | 200 | https://bisq-network.github.io/slate/No. introduction | deployed |
| Host API reference on https://bisq-network.github.io/slate | dev | 200 | https://github.com/bisq-network/slate/pulls?q=is%3Apr | merged |
| Exclude persistedAccountName from API payment acct json forms | dev | 100 | https://github.com/bisq-network/bisq/pull/6098 | merged |
| Send pretty payment details to API clients | dev | 100 | https://github.com/bisq-network/bisq/pull/6103 | merged |
<!--
Each contribution should be a new line-item in the table above.
Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.
Example 1 - typical contribution:
| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982
Example 2 - role (note the asterisk):
| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613
Example 3 - list of minor contributions, such as reviews:
| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.
-->
## Contributions in progress
> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._
- Working together with some individuals interested in running API bots, including representative at BTCPay.
- Will be working on a basic API daemon and CLI release, as an executable jar.
- Continue to simplify the API Python examples setup task.
- Improve API reference doc & examples as needed, fix API bugs when found.
--
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/1033
You are receiving this because you are subscribed to this thread.
Message ID: <bisq-network/compensation/issues/1033 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220324/523476e5/attachment.htm>
More information about the bisq-github
mailing list