[bisq-network/bisq] Support Bitcoin Core v22 RPC for JSON export (PR #6123)
chimp1984
notifications at github.com
Tue Mar 29 21:53:07 CEST 2022
@chimp1984 approved this pull request.
ACK
Tested with Bitcoin Core 19 and 22 and tested basic DAO use cases.
Left a comment, not sure if that is relevant to address.
> @@ -350,9 +352,14 @@ private static RawTx getTxFromRawTransaction(RawDtoTransaction rawDtoTx,
}
}
}
- // We don't support raw MS which are the only case where scriptPubKey.getAddresses()>1
- String address = scriptPubKey.getAddresses() != null &&
Is the addresses field in `DtoPubKeyScript` still valid/supported?
--
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6123#pullrequestreview-925096726
You are receiving this because you are subscribed to this thread.
Message ID: <bisq-network/bisq/pull/6123/review/925096726 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220329/b8e205d6/attachment.htm>
More information about the bisq-github
mailing list