<p></p>
<p>RE commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/ab17b672294011b766da3ab6e02a349c01c4f7e0/hovercard" href="https://github.com/bisq-network/bisq/commit/ab17b672294011b766da3ab6e02a349c01c4f7e0"><tt>ab17b67</tt></a>:  I was catching exceptions (indicating a bug or bugs to be fixed?) I've seen during testing this method.  Otherwise they will bubble up to client.</p>
<p>RE commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/916457963f56747fae53b78de288a774c0865761/hovercard" href="https://github.com/bisq-network/bisq/commit/916457963f56747fae53b78de288a774c0865761"><tt>9164579</tt></a>:  I don't think an extra line for an explicit <code>return;</code> is needed for methods that return void.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4214#issuecomment-623147601">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNR4RMLMSXY4VTRVJLTRPWRYLANCNFSM4MUIOB4Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUEUDLXME3XF7ICVILRPWRYLA5CNFSM4MUIOB42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEUSHUUI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4214#issuecomment-623147601",
"url": "https://github.com/bisq-network/bisq/pull/4214#issuecomment-623147601",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>