<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #5613.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="941249211" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5613" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/5613/hovercard" href="https://github.com/bisq-network/bisq/issues/5613">#5613</a></p>
<p>When loading payment accounts which have been deprecated, an exception is thrown which is not handled.  This causes the entire set of payment accounts to be lost.</p>
<p>To fix this we check for an exception when deserializing a payment account, and log a warning with the details.  The erroneous payment account will therefore be dropped from the list, which is what is expected.</p>
<p>I tested using the following procedure on both regtest & mainnet Bisq.</p>
<h3>Testing:</h3>
<ul>
<li>Create a new Bisq account using v1.6.5 (or earlier).</li>
<li>Add Amazon Giftcard and Chase QuickPay accounts for the user.</li>
<li>Close Bisq, log in again using the same version and check that both accounts are listed.</li>
<li>Close Bisq, upgrade to (v1.7.0 + this PR) and run it.</li>
<li>Check that the Chase QuickPay account is no longer in the list, but the Amazon Giftcard account is present.</li>
</ul>
<p>Check that a log warning is written, like this:</p>
<div class="snippet-clipboard-content position-relative" data-snippet-clipboard-copy-content="Jul-10 10:12:05.316 [PersistenceManager-read-UserPayload] WARN  b.core.payment.PaymentAccount: Could not load account: CHASE_QUICK_PAY, exception: java.lang.RuntimeException: Not supported PaymentMethod: PaymentMethod(id=N/A, maxTradePeriod=0, maxTradeLimit=0)
"><pre><code>Jul-10 10:12:05.316 [PersistenceManager-read-UserPayload] WARN  b.core.payment.PaymentAccount: Could not load account: CHASE_QUICK_PAY, exception: java.lang.RuntimeException: Not supported PaymentMethod: PaymentMethod(id=N/A, maxTradePeriod=0, maxTradeLimit=0)
</code></pre></div>
<p>(It will actually be logged 2 times since UserPreferences deserializes 2 times).</p>
<hr>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5614'>https://github.com/bisq-network/bisq/pull/5614</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>fix payment account deserialize issue (e.g. CHASE_QUICK_PAY)</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5614/files#diff-189dabf054a26f4cd086890f538252d6c47a246491d7d95e730ce6a0e640d786">core/src/main/java/bisq/core/payment/PaymentAccount.java</a>
    (29)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5614/files#diff-271d105578c820ebdad7cf65f91dfeda836479e5f956f199fc53e445e742e1df">core/src/main/java/bisq/core/user/UserPayload.java</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5614.patch'>https://github.com/bisq-network/bisq/pull/5614.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5614.diff'>https://github.com/bisq-network/bisq/pull/5614.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5614">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWFWZFDBZWUCOPWAEDTXBRNPANCNFSM5AEKTHTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUIRJ5LXDCVEBFAR4DTXBRNPA5CNFSM5AEKTHT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OA2VQVQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5614",
"url": "https://github.com/bisq-network/bisq/pull/5614",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>