[bisq-network/bisq] Fix base currency option handling (#2063)

[Chris Beams]

This change fixes #2048 by removing the assignment of a default value
for the `baseCurrencyNetwork` option at the level of the command line
option parser. The assignment of this default was an oversight in #1961
(specifically commit 83e1dd3) that did not account for the fact that
users can change the `baseCurrencyNetwork` value via the Settings screen
in the application. When users change the setting in the application, the new
value is persisted to <appDataDir>/bisq.properties, which is handled at
runtime as a PropertySource with lower precedence than the command line
property source, which means that the changed value is never picked up
because the higher-precedence command line PropertySource always has a
default value.

This fix is surgical in that it addresses only this specific option. A
subsequent change should address the more general issue that setting
defaults in the command line option parser always precludes the
possibility of overriding them in bisq.properties. Basically, we should
revert to the previous strategy of reporting what the default value will
be in the help text without actually assigning a default value in the
option parser using the `defaultsTo` method.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/2063

-- Commit Summary --

  * Fix base currency option handling

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqExecutable.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/2063.patch
https://github.com/bisq-network/bisq/pull/2063.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2063
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181205/ba2b10f2/attachment.html>