[bisq-network/bisq-core] Fix typos (#109)

[Chris Beams]

cbeams commented on this pull request.



> @@ -35,9 +35,9 @@ shared.no=No
 shared.iUnderstand=I understand
 shared.na=N/A
 shared.shutDown=Shut down
-shared.reportBug=Report bug at Github issues
-shared.buyBitcoin=Buy bitcoin
-shared.sellBitcoin=Sell bitcoin
+shared.reportBug=Report bug at GitHub issues
+shared.buyBitcoin=Buy Bitcoin
+shared.sellBitcoin=Sell Bitcoin

Some of the capitalizations of Bitcoin you've done in this PR are correct, and some should remain lower case. Please review the following resources regarding capitalization of the word bitcoin, and update the PR accordingly, thanks.

 - https://bitcoin.org/en/vocabulary#bitcoin
 - https://bitcoin.stackexchange.com/questions/20901/correct-use-of-the-word-bitcoin

> @@ -1293,7 +1293,7 @@ Please select one of the existing MultiSig transactions from your wallet which w
 deposit transaction used in the failed trade.\n\n\
 You can find the correct transaction by opening the trade details window (click on the trade ID in the list)\
  and following the trading fee payment transaction output to the next transaction where you see \
-the Multisig deposit transaction (the address starts with 3). That transaction ID should be \
+the MultiSig deposit transaction (the address starts with 3). That transaction ID should be \

Can you provide resources as to why it should be capitalized this way? My quick searching on the matter showed me that "Multisig" (lower case 's') is the more conventional form.

> @@ -1501,7 +1501,7 @@ systemTray.tooltip=Bisq: The decentralized exchange network
 ####################################################################
 
 guiUtil.miningFeeInfo=Please be sure that the mining fee used at your external wallet is \
-at least {0} Satoshi/Byte. Otherwise the trade transactions cannot be confirmed and a trade would end up in a dispute.
+at least {0} Satoshis/byte. Otherwise the trade transactions cannot be confirmed and a trade would end up in a dispute.

For the same reasons that the word "bitcoin" is spelled with a lower case 'b' when referring to bitcoin as a unit of currency, so too should "satoshi" be spelled with a lowercase 's'. For reference, see https://en.bitcoin.it/wiki/Satoshi_(unit).


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/109#pullrequestreview-118295139
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180508/1a142af1/attachment-0002.html>