[bisq-network/bisq] Fix for #2106 (#3040)

Florian Reimair notifications at github.com
Tue Aug 6 07:42:36 UTC 2019


freimair requested changes on this pull request.

NullPointerEx due to error in indexing. See the comment.

>                  columns[0] = model.getTradeId(item);
                 columns[1] = model.getDate(item);
                 columns[2] = model.getAmount(item);
                 columns[3] = model.getPrice(item);
                 columns[4] = model.getVolume(item);
+				columns[5] = model.getTxFee(item);
+				columns[6] = model.getMakerFee(item);
+				columns[7] = model.getBuyerSecurityDeposit(item);
+				columns[8] = model.getSellerSecurityDeposit(item);
                 columns[5] = model.getDirectionLabel(item);

there is something wrong with the indexing here. you added 5,6,7,8, yet, the last lines reassign 5 and 6. Ultimately resulting in a
```
java.lang.NullPointerException
	at com.googlecode.jcsv.writer.internal.CSVColumnJoinerImpl.joinColumns(CSVColumnJoinerImpl.java:30)
	at com.googlecode.jcsv.writer.internal.CSVWriterImpl.write(CSVWriterImpl.java:38)
	at com.googlecode.jcsv.writer.internal.CSVWriterImpl.writeAll(CSVWriterImpl.java:29)
	at bisq.desktop.util.GUIUtil.exportCSV(GUIUtil.java:266)
```
because 9 and 10 stay unassigned (null).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3040#pullrequestreview-271163685
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190806/98839e3c/attachment.html>


More information about the bisq-github mailing list