[bisq-network/bisq] use singleton annotation instead of binding as singleton (#3058)

Christoph Sturm notifications at github.com
Wed Aug 7 08:04:21 UTC 2019


definately the class, the class knows if its a singleton. also the problem is that even when the class is not defined in the module but still on the classpath it will be found by guice, but have the wrong lifecycle. doing it by annotation ensures that the lifecycle is always correct. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3058#issuecomment-518988272
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190807/46badbee/attachment.html>


More information about the bisq-github mailing list