[bisq-network/compensation] For Cycle 8 (#428)

[Justin Carter]

## Summary

This request includes contributions delivered in Cycles 6, 7 + 8.
Reasoning:
- in Cycle 6 I missed the deadline and as my Cycle 7 submission wasn't accepted this is still open
- in Cycle 7 I included line items / amounts that were contentious which I have amended in this proposal. (If there is still contention I hope this will be addressed before the voting).

BSQ requested: 11532BSQ total
Cycle 6: $4000 (@ 1 BSQ = 1 USD) => 4000BSQ
Cycle 7: $4000 (@ 1 BSQ = 0.79 USD) => 5063BSQ
Cycle 8: $2000 (@ 1 BSQ = 0.81 USD) => 2469BSQ

## Contributions delivered

### Cycle 8
- Completed the refactoring / removal of the `BSFormatter` class. [ 1500 USD ]
  [Tracking issue](https://github.com/bisq-network/bisq/issues/3240)
  Related PRs: https://github.com/bisq-network/bisq/pull/3253, https://github.com/bisq-network/bisq/pull/3634, https://github.com/bisq-network/bisq/pull/3658, https://github.com/bisq-network/bisq/pull/3661, https://github.com/bisq-network/bisq/pull/3674
- Assisted in the development of the [Makefile](https://github.com/bisq-network/bisq/blob/master/Makefile) used to improve onboarding / dev / test flow. [ 500 USD]
  Related PRs: https://github.com/bisq-network/bisq/pull/3718

### Cycle 7
- Discovered a [critical bug in a different hashing mechanism that _was_ acute](https://github.com/bisq-network/bisq/issues/3468) [ 1000 USD ]
- Re-implemented Bisq Markets API using caching proxy with @wiz https://github.com/bisq-network/bisq-markets/pull/20. This was to solve immediate acute issues with responsiveness and down time [ 1500 USD ]
- Implemented a service check to perform ping/pong validation of responsiveness of Bisq nodes for @wiz to monitor the uptime of seednodes on his monitoring alerts system [ 1500 USD ]
  Readme: https://github.com/bodymindarts/risq/#node-checker
  Code: https://github.com/bodymindarts/risq/blob/master/src/checker.rs
  Execution happens from @wiz' monitoring code which is closed source
<img width="584" alt="Screenshot 2019-11-10 at 15 38 16" src="https://user-images.githubusercontent.com/8533296/68549849-2aece980-03fd-11ea-8be4-22db24964ff3.png">

### Cycle 6
- Some small PRs to improving the code relating to the `BSFormatter` class. [ 1500 USD]
  https://github.com/bisq-network/bisq/pull/3239
  https://github.com/bisq-network/bisq/pull/3244
- Discovered one of the hashing mechanisms used in Bisq is unstable due to its dependency on protobufs which is a _non-deterministic_ serialization format. My investigation revealed it is dangerous but we are okay for the time being thanks to an implementation detail of the java protobuf lib [findings of investigation](https://github.com/bisq-network/bisq/issues/3391) [ 2500 USD ]

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/428
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191211/7748b273/attachment.html>