[bisq-network/bisq] Navigate to bond (#2354)

Manfred Karrer notifications at github.com
Sun Feb 3 00:27:07 UTC 2019

ManfredKarrer requested changes on this pull request.

>  @Slf4j
 public final class Navigation implements PersistedDataHost {
     private static final ViewPath DEFAULT_VIEW_PATH = ViewPath.to(MainView.class, MarketView.class);
     public interface Listener {
-        void onNavigationRequested(ViewPath path);
+        void onNavigationRequested(ViewPath path, @Nullable Object data);

 I think its better to make a second method with the additional param.

public interface Listener {
        default void onNavigationRequested(ViewPath path){
            onNavigationRequested(path, null);
        default void onNavigationRequested(ViewPath path, @Nullable Object data){

Then you can avoid all those changed in clients where you pass null. Using `default` does not force implementing clients to define both methods. 

>      }
-    public void navigateTo(ViewPath newPath) {
+    public void navigateTo(ViewPath newPath, Object data) {

Can you add @Nullable

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190202/3d0b32e6/attachment.html>

More information about the bisq-github mailing list