[bisq-network/bisq] Improve handling when unable to connect to tor (#2399)

Florian Reimair notifications at github.com
Wed Feb 13 10:12:29 UTC 2019


freimair commented on this pull request.



>                  // Furthermore, we have no hidden services started yet, so there is no graceful
                 // shutdown needed either
-                System.exit(1);
+                UserThread.execute(() -> {
+                    setupListeners.stream().forEach(s -> s.onSetupFailed(new RuntimeException(e.getMessage())));
+                });
             } catch (Throwable ignore) {
             }

Maybe we can force `onSuccess` by `return null;` after triggering the `onSetupFailed` and let the `onFailure` be?

And yes, this class cries for being refactored :)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2399#discussion_r256326298
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190213/cbf4ff9c/attachment.html>


More information about the bisq-github mailing list